lkml.org 
[lkml]   [2020]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2] i2c: slave-eeprom: Make it possible to pre-load eeprom data

On second look, two questions:

> + if (!error) {
> + int ret = request_firmware_into_buf(&fw, eeprom_data, &client->dev,
> + eeprom->buffer, size);
> + if (ret)
> + return ret;

Aren't we leaking 'fw' here?

Also, do we need 'error' and 'ret'? Can't we reuse one of them?

> + release_firmware(fw);

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-04-24 13:15    [W:0.098 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site