Messages in this thread | | | Date | Fri, 24 Apr 2020 13:13:37 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCHv2] i2c: slave-eeprom: Make it possible to pre-load eeprom data |
| |
On second look, two questions:
> + if (!error) { > + int ret = request_firmware_into_buf(&fw, eeprom_data, &client->dev, > + eeprom->buffer, size); > + if (ret) > + return ret;
Aren't we leaking 'fw' here?
Also, do we need 'error' and 'ret'? Can't we reuse one of them?
> + release_firmware(fw);
[unhandled content-type:application/pgp-signature]
| |