Messages in this thread | | | Subject | Re: [PATCH v2 09/11] perf metrics: fix parse errors in power9 metrics | From | Paul Clarke <> | Date | Wed, 22 Apr 2020 17:31:40 -0500 |
| |
On 4/22/20 5:04 PM, Ian Rogers wrote: > Mismatched parentheses. > > Fixes: 7f3cf5ac7743 (perf vendor events power9: Cpi_breakdown & estimated_dcache_miss_cpi metrics) > Signed-off-by: Ian Rogers <irogers@google.com> > --- > tools/perf/pmu-events/arch/powerpc/power9/metrics.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/pmu-events/arch/powerpc/power9/metrics.json b/tools/perf/pmu-events/arch/powerpc/power9/metrics.json > index 811c2a8c1c9e..f427436f2c0a 100644 > --- a/tools/perf/pmu-events/arch/powerpc/power9/metrics.json > +++ b/tools/perf/pmu-events/arch/powerpc/power9/metrics.json > @@ -362,7 +362,7 @@ > }, > { > "BriefDescription": "Completion stall for other reasons", > - "MetricExpr": "PM_CMPLU_STALL - PM_CMPLU_STALL_NTC_DISP_FIN - PM_CMPLU_STALL_NTC_FLUSH - PM_CMPLU_STALL_LSU - PM_CMPLU_STALL_EXEC_UNIT - PM_CMPLU_STALL_BRU)/PM_RUN_INST_CMPL", > + "MetricExpr": "(PM_CMPLU_STALL - PM_CMPLU_STALL_NTC_DISP_FIN - PM_CMPLU_STALL_NTC_FLUSH - PM_CMPLU_STALL_LSU - PM_CMPLU_STALL_EXEC_UNIT - PM_CMPLU_STALL_BRU)/PM_RUN_INST_CMPL",
OK. (Thank you!!)
> "MetricGroup": "cpi_breakdown", > "MetricName": "other_stall_cpi" > },
Reviewed-by: Paul A. Clarke <pc@us.ibm.com>
(I like how you got the "power8" changes to be 8th in the series and the "power9" changes to be 9th ;-)
PC
| |