Messages in this thread Patch in this message | | | From | Guenter Roeck <> | Subject | [PATCH] RISC-V: stacktrace: Declare sp_in_global outside ifdef | Date | Mon, 13 Apr 2020 09:12:34 -0700 |
| |
riscv:allnoconfig and riscv:tinyconfig fail to compile.
arch/riscv/kernel/stacktrace.c: In function 'walk_stackframe': arch/riscv/kernel/stacktrace.c:78:8: error: 'sp_in_global' undeclared
sp_in_global is declared inside CONFIG_FRAME_POINTER but used outside of it.
Fixes: 52e7c52d2ded ("RISC-V: Stop relying on GCC's register allocator's hueristics") Cc: Palmer Dabbelt <palmerdabbelt@google.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- Apologies for the noise if this has already been fixed somewhere.
arch/riscv/kernel/stacktrace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/riscv/kernel/stacktrace.c b/arch/riscv/kernel/stacktrace.c index 02087fe539c6..6c854875ac74 100644 --- a/arch/riscv/kernel/stacktrace.c +++ b/arch/riscv/kernel/stacktrace.c @@ -12,6 +12,8 @@ #include <linux/stacktrace.h> #include <linux/ftrace.h> +register unsigned long sp_in_global __asm__("sp"); + #ifdef CONFIG_FRAME_POINTER struct stackframe { @@ -19,8 +21,6 @@ struct stackframe { unsigned long ra; }; -register unsigned long sp_in_global __asm__("sp"); - void notrace walk_stackframe(struct task_struct *task, struct pt_regs *regs, bool (*fn)(unsigned long, void *), void *arg) { -- 2.17.1
| |