lkml.org 
[lkml]   [2020]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */ comments to fallthrough;
From
Date
On Sun, 2020-03-08 at 14:14 -0500, Gustavo A. R. Silva wrote:
>
> On 3/8/20 03:58, Joe Perches wrote:
> > On Sun, 2020-03-08 at 01:11 -0600, Gustavo A. R. Silva wrote:
> > > On 3/8/20 01:02, Joe Perches wrote:
> > > > > or if you are suggesting that
> > > > > the maintainers will have the predisposition of applying
> > > > > patches that will modify their coding style and then go and
> > > > > willingly fix that. I doubt the latter, though.
> > > >
> > > > If any do actually use the script, I guess we'll see.
> > > >
> > > Yep. In the meantime is a NACK from me for this version
> > > of your patch.
> >
> > Generic code reformatters of comments to code are not
> > particularly common.
> >
>
> It's no a matter of
> reformatting something. It's the opposite, it's a matter of
> not messing (removing existing blank lines) with the current
> format and merely focusing on replacing comments.

You are not correct in your assumption.

This is precisely reformatting of comments to code.

Nor are you correct in what appears to be your
general point. It's quite fine to reformat comments
for consistency.


\
 
 \ /
  Last update: 2020-03-08 20:46    [W:0.063 / U:0.836 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site