lkml.org 
[lkml]   [2020]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */ comments to fallthrough;
From
Date
On Sun, 2020-03-08 at 01:11 -0600, Gustavo A. R. Silva wrote:
> On 3/8/20 01:02, Joe Perches wrote:
> > > or if you are suggesting that
> > > the maintainers will have the predisposition of applying
> > > patches that will modify their coding style and then go and
> > > willingly fix that. I doubt the latter, though.
> >
> > If any do actually use the script, I guess we'll see.
> >
> Yep. In the meantime is a NACK from me for this version
> of your patch.

Generic code reformatters of comments to code are not
particularly common.

Instead of suggesting a nak for something that works
pretty well, it would perhaps be more fruitful if you
were to try either to write something else or try to
improve the existing code.

I'd be interested in seeing whatever code you produce.

cheers, Joe


\
 
 \ /
  Last update: 2020-03-08 10:01    [W:0.062 / U:32.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site