Messages in this thread | | | Subject | Re: [PATCH v1] net: phy: tja11xx: add TJA1102 support | From | Marc Kleine-Budde <> | Date | Tue, 3 Mar 2020 15:11:02 +0100 |
| |
On 3/3/20 3:09 PM, Andrew Lunn wrote: >>> Hi Oleksij, Heiner, Marc, >>> >>> You could also refer the solution implemented here as part of a TJA110x driver: >>> https://source.codeaurora.org/external/autoivnsw/tja110x_linux_phydev/about/ >> >> OK, thank you! >> >> Suddenly, the solution in this driver is not mainlainable. It may match on >> ther PHYs with PHYID == 0. >> >> See this part of the code: >> #define NXP_PHY_ID_TJA1102P1 (0x00000000U) >> ... >> , { >> .phy_id = NXP_PHY_ID_TJA1102P1, >> .name = "TJA1102_p1", >> .phy_id_mask = NXP_PHY_ID_MASK, > > Noooo > > You cannot assume NXP is the only silicon vendor to manufacture broken > silicon with a PHY ID of 0.
ACK, we ruled that soultion out already :)
We'll look into your and Marek's suggestions.
Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |