lkml.org 
[lkml]   [2020]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1] net: phy: tja11xx: add TJA1102 support
From
Date
On 3/3/20 3:09 PM, Andrew Lunn wrote:
>>> Hi Oleksij, Heiner, Marc,
>>>
>>> You could also refer the solution implemented here as part of a TJA110x driver:
>>> https://source.codeaurora.org/external/autoivnsw/tja110x_linux_phydev/about/
>>
>> OK, thank you!
>>
>> Suddenly, the solution in this driver is not mainlainable. It may match on
>> ther PHYs with PHYID == 0.
>>
>> See this part of the code:
>> #define NXP_PHY_ID_TJA1102P1 (0x00000000U)
>> ...
>> , {
>> .phy_id = NXP_PHY_ID_TJA1102P1,
>> .name = "TJA1102_p1",
>> .phy_id_mask = NXP_PHY_ID_MASK,
>
> Noooo
>
> You cannot assume NXP is the only silicon vendor to manufacture broken
> silicon with a PHY ID of 0.

ACK, we ruled that soultion out already :)

We'll look into your and Marek's suggestions.

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

\
 
 \ /
  Last update: 2020-03-03 15:12    [W:0.033 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site