lkml.org 
[lkml]   [2020]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] net: phy: tja11xx: add TJA1102 support
> > Hi Oleksij, Heiner, Marc,
> >
> > You could also refer the solution implemented here as part of a TJA110x driver:
> > https://source.codeaurora.org/external/autoivnsw/tja110x_linux_phydev/about/
>
> OK, thank you!
>
> Suddenly, the solution in this driver is not mainlainable. It may match on
> ther PHYs with PHYID == 0.
>
> See this part of the code:
> #define NXP_PHY_ID_TJA1102P1 (0x00000000U)
> ...
> , {
> .phy_id = NXP_PHY_ID_TJA1102P1,
> .name = "TJA1102_p1",
> .phy_id_mask = NXP_PHY_ID_MASK,

Noooo

You cannot assume NXP is the only silicon vendor to manufacture broken
silicon with a PHY ID of 0.

Andrew

\
 
 \ /
  Last update: 2020-03-03 15:11    [W:0.036 / U:0.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site