lkml.org 
[lkml]   [2020]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] kconfig: remove unused variable in qconf.cc
On Thu, Mar 26, 2020 at 11:06 AM Kees Cook <keescook@chromium.org> wrote:
>
> On Wed, Mar 25, 2020 at 12:14:31PM +0900, Masahiro Yamada wrote:
> > If this file were compiled with -Wall, the following warning would be
> > reported:
> >
> > scripts/kconfig/qconf.cc:312:6: warning: unused variable ‘i’ [-Wunused-variable]
> > int i;
> > ^
> >
> > The commit prepares to turn on -Wall for C++ host programs.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>

Applied to linux-kbuild.



> -Kees
>
> > ---
> >
> > scripts/kconfig/qconf.cc | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
> > index 82773cc35d35..50a5245d87bb 100644
> > --- a/scripts/kconfig/qconf.cc
> > +++ b/scripts/kconfig/qconf.cc
> > @@ -309,8 +309,6 @@ ConfigList::ConfigList(ConfigView* p, const char *name)
> > showName(false), showRange(false), showData(false), mode(singleMode), optMode(normalOpt),
> > rootEntry(0), headerPopup(0)
> > {
> > - int i;
> > -
> > setObjectName(name);
> > setSortingEnabled(false);
> > setRootIsDecorated(true);
> > --
> > 2.17.1
> >
>
> --
> Kees Cook



--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2020-03-29 13:05    [W:0.051 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site