lkml.org 
[lkml]   [2020]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] kconfig: remove unused variable in qconf.cc
On Wed, Mar 25, 2020 at 12:14:31PM +0900, Masahiro Yamada wrote:
> If this file were compiled with -Wall, the following warning would be
> reported:
>
> scripts/kconfig/qconf.cc:312:6: warning: unused variable ‘i’ [-Wunused-variable]
> int i;
> ^
>
> The commit prepares to turn on -Wall for C++ host programs.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>
> scripts/kconfig/qconf.cc | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
> index 82773cc35d35..50a5245d87bb 100644
> --- a/scripts/kconfig/qconf.cc
> +++ b/scripts/kconfig/qconf.cc
> @@ -309,8 +309,6 @@ ConfigList::ConfigList(ConfigView* p, const char *name)
> showName(false), showRange(false), showData(false), mode(singleMode), optMode(normalOpt),
> rootEntry(0), headerPopup(0)
> {
> - int i;
> -
> setObjectName(name);
> setSortingEnabled(false);
> setRootIsDecorated(true);
> --
> 2.17.1
>

--
Kees Cook

\
 
 \ /
  Last update: 2020-03-26 03:07    [W:0.079 / U:3.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site