lkml.org 
[lkml]   [2020]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v3 01/11] net: ethernet: ti: cpts: use dev_yy() api for logs
On Fri, Mar 20, 2020 at 09:42:34PM +0200, Grygorii Strashko wrote:
> @@ -150,7 +150,7 @@ static int cpts_fifo_read(struct cpts *cpts, int match)
> break;
>
> if (list_empty(&cpts->pool) && cpts_purge_events(cpts)) {
> - pr_err("cpts: event pool empty\n");
> + dev_info(cpts->dev, "cpts: event pool empty\n");

You changed err into info. Was that on purpose?

The size of the pool is hard coded, but it should be large enough for
any use case. If the pool size turns out to be too small at run time,
then I think the message deserves at least the level of warning.

Thanks,
Richard

\
 
 \ /
  Last update: 2020-03-26 15:06    [W:0.076 / U:16.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site