lkml.org 
[lkml]   [2020]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next v3 06/11] net: ethernet: ti: cpts: move tx timestamp processing to ptp worker only
From
Date


On 26/03/2020 16:29, Richard Cochran wrote:
> On Fri, Mar 20, 2020 at 09:42:39PM +0200, Grygorii Strashko wrote:
>> Now the tx timestamp processing happens from different contexts - softirq
>> and thread/PTP worker. Enabling IRQ will add one more hard_irq context.
>> This makes over all defered TX timestamp processing and locking
>> overcomplicated. Move tx timestamp processing to PTP worker always instead.
>>
>> napi_rx->cpts_tx_timestamp
>> if ptp_packet then
>> push to txq
>> ptp_schedule_worker()
>>
>> do_aux_work->cpts_overflow_check
>> cpts_process_events()
>
> Since cpts_overflow_check() is performing new functions, consider
> renaming it to match.

It's still performs overflow check

static long cpts_overflow_check(struct ptp_clock_info *ptp)
{
...

mutex_lock(&cpts->ptp_clk_mutex);

cpts_update_cur_time(cpts, -1, NULL);
^^^ here
ns = timecounter_read(&cpts->tc);


cpts_process_events(cpts);

What name would you suggest?

Thank you.

--
Best regards,
grygorii

\
 
 \ /
  Last update: 2020-03-26 21:17    [W:0.073 / U:4.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site