lkml.org 
[lkml]   [2020]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/2] amba/platform: Initialize dma_parms at the bus level
Date
It's currently the amba/platform driver's responsibility to initialize the
pointer, dma_parms, for its corresponding struct device. The benefit with this
approach allows us to avoid the initialization and to not waste memory for the
struct device_dma_parameters, as this can be decided on a case by case basis.

However, it has turned out that this approach is not very practical. Not only
does it lead to open coding, but also to real errors. In principle callers of
dma_set_max_seg_size() doesn't check the error code, but just assumes it
succeeds.

For these reasons, this series initializes the dma_parms from the amba/platform
bus at the device registration point. This also follows the way the PCI devices
are being managed, see pci_device_add().

If it turns out that this is an acceptable solution, we probably also want the
changes for stable, but I am not sure if it applies without conflicts.

The series is based on v5.6-rc7.

Kind regards
Ulf Hansson

Ulf Hansson (2):
driver core: platform: Initialize dma_parms for platform devices
amba: Initialize dma_parms for amba devices

drivers/amba/bus.c | 2 ++
drivers/base/platform.c | 1 +
include/linux/amba/bus.h | 1 +
include/linux/platform_device.h | 1 +
4 files changed, 5 insertions(+)

--
2.20.1

\
 
 \ /
  Last update: 2020-03-25 12:34    [W:0.109 / U:6.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site