Messages in this thread | | | Date | Tue, 24 Mar 2020 21:57:31 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH v3] i2c: nvidia-gpu: Handle timeout correctly in gpu_i2c_check_status() |
| |
On Tue, Mar 24, 2020 at 11:28:11PM +0800, Kai-Heng Feng wrote: > Nvidia card may come with a "phantom" UCSI device, and its driver gets > stuck in probe routine, prevents any system PM operations like suspend. > > There's an unaccounted case that the target time can equal to jiffies in > gpu_i2c_check_status(), let's solve that by using readl_poll_timeout() > instead of jiffies comparison functions. > > Fixes: c71bcdcb42a7 ("i2c: add i2c bus driver for NVIDIA GPU") > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Looks good to me, thanks Andy for the suggestion!
Waiting for the Rev-by from Ajay (driver maintainer).
[unhandled content-type:application/pgp-signature] | |