lkml.org 
[lkml]   [2020]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v2 6/8] MIPS: DTS: jz4780: account for Synopsys HDMI driver and LCD controller
Hi Nikolaus,


Le ven., févr. 28, 2020 at 19:19, H. Nikolaus Schaller
<hns@goldelico.com> a écrit :
> From: Paul Boddie <paul@boddie.org.uk>
>
> A specialisation of the generic Synopsys HDMI driver is employed for
> JZ4780
> HDMI support. This requires a new driver, plus device tree and
> configuration
> modifications.
>
> Signed-off-by: Paul Boddie <paul@boddie.org.uk>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> arch/mips/boot/dts/ingenic/jz4780.dtsi | 32
> ++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> index f928329b034b..391d4e1efd35 100644
> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> @@ -433,4 +433,36 @@
>
> status = "disabled";
> };
> +
> + hdmi: hdmi@10180000 {
> + compatible = "ingenic,jz4780-dw-hdmi";
> + reg = <0x10180000 0x8000>;
> + reg-io-width = <4>;
> +
> + clocks = <&cgu JZ4780_CLK_HDMI>, <&cgu JZ4780_CLK_AHB0>;
> + clock-names = "isfr" , "iahb";
> +
> + assigned-clocks = <&cgu JZ4780_CLK_HDMI>;
> + assigned-clock-rates = <27000000>;

I *think* this should go to the board file.

> +
> + interrupt-parent = <&intc>;
> + interrupts = <3>;
> +
> + /* ddc-i2c-bus = <&i2c4>; */
> +
> + status = "disabled";
> + };
> +
> + lcd: lcd@13050000 {

The node name should be 'lcd-controller'.

> + compatible = "ingenic,jz4740-lcd";

The JZ4780's LCD controller is much newer than the JZ4740 one, so even
if it works with the "ingenic,jz4740-lcd" compatible string, you want
it as a fallback.
So this should be: compatible = "ingenic,jz4780-lcd",
"ingenic,jz4740-lcd".

That means the YAML should be updated too.

-Paul

> + reg = <0x13050000 0x1800>;
> +
> + clocks = <&cgu JZ4780_CLK_TVE>, <&cgu JZ4780_CLK_LCD0PIXCLK>;
> + clock-names = "lcd", "lcd_pclk";
> +
> + interrupt-parent = <&intc>;
> + interrupts = <31>;
> +
> + status = "disabled";
> + };
> };
> --
> 2.23.0
>


\
 
 \ /
  Last update: 2020-03-02 20:28    [W:0.758 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site