lkml.org 
[lkml]   [2020]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v2 2/8] dt-bindings: display: add ingenic-jz4780-hdmi DT Schema
Hi Nikolaus,


Le ven., févr. 28, 2020 at 19:19, H. Nikolaus Schaller
<hns@goldelico.com> a écrit :
> From: Sam Ravnborg <sam@ravnborg.org>
>
> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC.
> Based on .txt binding from Zubair Lutfullah Kakakhel
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
> Cc: H. Nikolaus Schaller <hns@goldelico.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> ---
> .../bindings/display/ingenic-jz4780-hdmi.yaml | 83
> +++++++++++++++++++
> 1 file changed, 83 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
> b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
> new file mode 100644
> index 000000000000..9b71c427bd69
> --- /dev/null
> +++
> b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
> @@ -0,0 +1,83 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/ingenic-jz4780-hdmi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bindings for Ingenic JZ4780 HDMI Transmitter
> +
> +maintainers:
> + - Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
> + - H. Nikolaus Schaller <hns@goldelico.com>

Did Zubair write this glue driver? He's been MIA for a while, doesn't
work at ImgTec anymore, and this email doesn't work.

> +
> +description: |
> + The HDMI Transmitter in the Ingenic JZ4780 is a Synopsys
> DesignWare HDMI 1.4
> + TX controller IP with accompanying PHY IP.
> +
> +allOf:
> + - $ref: panel/panel-common.yaml#
> +
> +properties:
> + compatible:
> + items:
> + - const: ingenic,jz4780-hdmi
> +
> + reg:
> + maxItems: 1
> + description: the address & size of the LCD controller registers

Remove the description here,

> +
> + reg-io-width:
> + const: 4
> +
> + interrupts:
> + maxItems: 1
> + description: Specifies the interrupt provided by parent

and here.

The rule is that if there is only one "reg", "interrupts" or "clocks"
entry then a description is not needed as it's pretty obvious what it's
for.

> +
> + clocks:
> + maxItems: 2
> + description: Clock specifiers for isrf and iahb clocks

You need two 'description:' like this:

clocks:
items:
- description: ISRF clock
- description: IAHB clock

Cheers,
-Paul

> +
> + clock-names:
> + items:
> + - const: isfr
> + - const: iahb
> +
> + ddc-i2c-bus: true
> + ports: true
> +
> +required:
> + - compatible
> + - clocks
> + - clock-names
> + - ports
> + - reg-io-width
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/jz4780-cgu.h>
> +
> + hdmi: hdmi@10180000 {
> + compatible = "ingenic,jz4780-hdmi";
> + reg = <0x10180000 0x8000>;
> + reg-io-width = <4>;
> + ddc-i2c-bus = <&i2c4>;
> + interrupt-parent = <&intc>;
> + interrupts = <3>;
> + clocks = <&cgu JZ4780_CLK_HDMI>, <&cgu JZ4780_CLK_AHB0>;
> + clock-names = "isfr", "iahb";
> +
> + ports {
> + hdmi_in: port {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + hdmi_in_lcd: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&jz4780_out_hdmi>;
> + };
> + };
> + };
> + };
> +
> +...
> --
> 2.23.0
>


\
 
 \ /
  Last update: 2020-03-02 20:20    [W:0.187 / U:5.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site