Messages in this thread | | | From | Jakub Sitnicki <> | Subject | Re: [PATCH bpf-next] bpf: tcp: Fix unused function warnings | Date | Thu, 19 Mar 2020 18:00:24 +0100 |
| |
On Thu, Mar 19, 2020 at 01:46 PM CET, YueHaibing wrote: > If BPF_STREAM_PARSER is not set, gcc warns: > > net/ipv4/tcp_bpf.c:483:12: warning: 'tcp_bpf_sendpage' defined but not used [-Wunused-function] > net/ipv4/tcp_bpf.c:395:12: warning: 'tcp_bpf_sendmsg' defined but not used [-Wunused-function] > net/ipv4/tcp_bpf.c:13:13: warning: 'tcp_bpf_stream_read' defined but not used [-Wunused-function] > > Moves the unused functions into the #ifdef > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > ---
In addition to this fix, looks like tcp_bpf_recvmsg can be static and also conditional on CONFIG_BPF_STREAM_PARSER.
Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
| |