lkml.org 
[lkml]   [2020]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH bpf-next 1/2] bpf: tcp: Fix unused function warnings
From
Date
On 3/20/20 5:21 AM, Yonghong Song wrote:
> On 3/19/20 7:34 PM, YueHaibing wrote:
>> If BPF_STREAM_PARSER is not set, gcc warns:
>>
>> net/ipv4/tcp_bpf.c:483:12: warning: 'tcp_bpf_sendpage' defined but not used [-Wunused-function]
>> net/ipv4/tcp_bpf.c:395:12: warning: 'tcp_bpf_sendmsg' defined but not used [-Wunused-function]
>> net/ipv4/tcp_bpf.c:13:13: warning: 'tcp_bpf_stream_read' defined but not used [-Wunused-function]
>>
>> Moves the unused functions into the #ifdef
>
> Maybe explicit "into the #ifdef CONFIG_BPF_STREAM_PARSER"?
>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: f747632b608f ("bpf: sockmap: Move generic sockmap hooks from BPF TCP")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> Reviewed-by: Lorenz Bauer <lmb@cloudflare.com>
>> Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
>
> Acked-by: Yonghong Song <yhs@fb.com>

Both applied and addressed feedback from Yonghong, thanks!

\
 
 \ /
  Last update: 2020-03-20 16:02    [W:0.054 / U:6.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site