Messages in this thread | | | Subject | Re: [PATCH net] ipv6: don't auto-add link-local address to lag ports | From | Eric Dumazet <> | Date | Wed, 18 Mar 2020 11:02:01 -0700 |
| |
On 3/18/20 7:06 AM, Jarod Wilson wrote: > Bonding slave and team port devices should not have link-local addresses > automatically added to them, as it can interfere with openvswitch being > able to properly add tc ingress. > > Reported-by: Moshe Levi <moshele@mellanox.com> > CC: Marcelo Ricardo Leitner <mleitner@redhat.com> > CC: netdev@vger.kernel.org > Signed-off-by: Jarod Wilson <jarod@redhat.com>
This does not look a net candidate to me, unless the bug has been added recently ?
The absence of Fixes: tag is a red flag for a net submission.
By adding a Fixes: tag, you are doing us a favor, please.
Thanks.
> --- > net/ipv6/addrconf.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index 46d614b611db..aed891695084 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -3296,6 +3296,10 @@ static void addrconf_addr_gen(struct inet6_dev *idev, bool prefix_route) > if (netif_is_l3_master(idev->dev)) > return; > > + /* no link local addresses on bond slave or team port devices */ > + if (netif_is_lag_port(idev->dev)) > + return; > + > ipv6_addr_set(&addr, htonl(0xFE800000), 0, 0, 0); > > switch (idev->cnf.addr_gen_mode) { >
| |