Messages in this thread | | | Subject | Re: [PATCH v3 14/27] powerpc/powernv/pmem: Add support for Admin commands | From | Andrew Donnellan <> | Date | Thu, 27 Feb 2020 19:27:16 +1100 |
| |
On 27/2/20 7:22 pm, Andrew Donnellan wrote: >> +int admin_command_request(struct ocxlpmem *ocxlpmem, u8 op_code) >> +{ >> + u64 val; >> + int rc = ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, >> GLOBAL_MMIO_CHI, >> + OCXL_LITTLE_ENDIAN, &val); >> + if (rc) >> + return rc; > > Ignoring the value here expected, you're just trying to verify that you > don't see an error on the read?
I see that in the next patch, in ns_command_request() you check that NSCRA is 1 - did you mean to check that ACRA = 1 here?
-- Andrew Donnellan OzLabs, ADL Canberra ajd@linux.ibm.com IBM Australia Limited
| |