lkml.org 
[lkml]   [2020]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 14/27] powerpc/powernv/pmem: Add support for Admin commands
From
Date
On Thu, 2020-02-27 at 19:27 +1100, Andrew Donnellan wrote:
> On 27/2/20 7:22 pm, Andrew Donnellan wrote:
> > > +int admin_command_request(struct ocxlpmem *ocxlpmem, u8 op_code)
> > > +{
> > > + u64 val;
> > > + int rc = ocxl_global_mmio_read64(ocxlpmem->ocxl_afu,
> > > GLOBAL_MMIO_CHI,
> > > + OCXL_LITTLE_ENDIAN, &val);
> > > + if (rc)
> > > + return rc;
> >
> > Ignoring the value here expected, you're just trying to verify that
> > you
> > don't see an error on the read?
>
> I see that in the next patch, in ns_command_request() you check that
> NSCRA is 1 - did you mean to check that ACRA = 1 here?
>
>

I was in one version, but that was causing problems in startup since
there was successful prior command to assert ACRA.

I should remove the NSCRA check too.

--
Alastair D'Silva
Open Source Developer
Linux Technology Centre, IBM Australia
mob: 0423 762 819

\
 
 \ /
  Last update: 2020-02-28 00:55    [W:2.291 / U:1.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site