[lkml]   [2020]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH v3 08/15] powerpc: Replace cpu_up/down with add/remove_cpu
The core device API performs extra housekeeping bits that are missing
from directly calling cpu_up/down.

See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and
serialization during LPM") for an example description of what might go

This also prepares to make cpu_up/down a private interface for anything
but the cpu subsystem.

Acked-by: Michael Ellerman <>
Signed-off-by: Qais Yousef <>
CC: Benjamin Herrenschmidt <>
CC: Paul Mackerras <>
CC: Michael Ellerman <>
CC: Enrico Weigelt <>
CC: Ram Pai <>
CC: Nicholas Piggin <>
CC: Thiago Jung Bauermann <>
CC: Christophe Leroy <>
CC: Thomas Gleixner <>

Michael, this now uses add_cpu() which you should be CCed on. I wasn't sure if
I can keep your Ack or remove it in this case. Please let me know if you need
more clarification.

arch/powerpc/kexec/core_64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kexec/core_64.c b/arch/powerpc/kexec/core_64.c
index 04a7cba58eff..b4184092172a 100644
--- a/arch/powerpc/kexec/core_64.c
+++ b/arch/powerpc/kexec/core_64.c
@@ -212,7 +212,7 @@ static void wake_offline_cpus(void)
if (!cpu_online(cpu)) {
printk(KERN_INFO "kexec: Waking offline cpu %d.\n",
- WARN_ON(cpu_up(cpu));
+ WARN_ON(add_cpu(cpu));
 \ /
  Last update: 2020-02-23 20:30    [W:0.025 / U:3.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site