Messages in this thread | | | Date | Fri, 21 Feb 2020 17:05:18 +0200 | From | Laurent Pinchart <> | Subject | Re: [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal |
| |
Hi Torsten,
On Fri, Feb 21, 2020 at 04:01:17PM +0100, Torsten Duwe wrote: > On Fri, Feb 21, 2020 at 03:39:32PM +0100, Thomas Zimmermann wrote: > > Am 21.02.20 um 15:04 schrieb Torsten Duwe: > > > drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by > > > and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0] > > > and the multiply+divide alltogether. > > > > > > fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5") > > > > You have to create the fixes tag and related cc tags with 'dim fixes', > > available at [1]. For this patch, the output is > > > > Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5") > > Cc: Torsten Duwe <duwe@suse.de> > > Cc: Maxime Ripard <maxime@cerno.tech> > > Cc: Torsten Duwe <duwe@lst.de> > > Cc: Sam Ravnborg <sam@ravnborg.org> > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > Cc: Icenowy Zheng <icenowy@aosc.io> > > Cc: Stephen Rothwell <sfr@canb.auug.org.au> > > Ah, neat. > > > > Signed-off-by: Torsten Duwe <duwe@suse.de> > > > > You signed off with your SUSE email address, but sent the mail from > > lst.de. I don't know if it's strictly not allowed, but that's at least > > confusing to the tools. > > From my understanding, it is legally correct. The work is owned by Suse, > so I have to sign off as an employee, but I'm subscribed with the LST > address, and I'd also like to see all replies there.
That's fine, but then the mail body should start with a From: line that matches the address used in Signed-off-by. git-send-email should generate that automatically.
> > [1] https://gitlab.freedesktop.org/drm/maintainer-tools/ > > I'll send an appropriate v2 once I get a review for it.
-- Regards,
Laurent Pinchart
| |