Messages in this thread | | | Subject | Re: [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal | From | Thomas Zimmermann <> | Date | Fri, 21 Feb 2020 15:39:32 +0100 |
| |
Hi Torsten
Am 21.02.20 um 15:04 schrieb Torsten Duwe: > drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by > and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0] > and the multiply+divide alltogether. > > fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5")
You have to create the fixes tag and related cc tags with 'dim fixes', available at [1]. For this patch, the output is
Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5") Cc: Torsten Duwe <duwe@suse.de> Cc: Maxime Ripard <maxime@cerno.tech> Cc: Torsten Duwe <duwe@lst.de> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Icenowy Zheng <icenowy@aosc.io> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Torsten Duwe <duwe@suse.de>
You signed off with your SUSE email address, but sent the mail from lst.de. I don't know if it's strictly not allowed, but that's at least confusing to the tools.
Best regards Thomas
[1] https://gitlab.freedesktop.org/drm/maintainer-tools/
> --- > https://patchwork.freedesktop.org/patch/343004/ > https://lists.freedesktop.org/archives/dri-devel/2020-January/253535.html > > Can someone please review this? It's equivalent to commit > 3e138a63d6674a4567a018a31 which just made it into drm-tip. > > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > @@ -210,10 +210,9 @@ static int anx6345_dp_link_training(struct anx6345 *anx6345) > if (err) > return err; > > - dpcd[0] = drm_dp_max_link_rate(anx6345->dpcd); > - dpcd[0] = drm_dp_link_rate_to_bw_code(dpcd[0]); > err = regmap_write(anx6345->map[I2C_IDX_DPTX], > - SP_DP_MAIN_LINK_BW_SET_REG, dpcd[0]); > + SP_DP_MAIN_LINK_BW_SET_REG, > + anx6345->dpcd[DP_MAX_LINK_RATE]); > if (err) > return err; > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel >
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
[unhandled content-type:application/pgp-signature] | |