Messages in this thread Patch in this message | | | From | Andy Shevchenko <> | Subject | [PATCH v1] mfd: dln2: Fix sanity checking for endpoints | Date | Tue, 18 Feb 2020 15:43:48 +0200 |
| |
While the commit 2b8bd606b1e6 ("mfd: dln2: More sanity checking for endpoints") tries to harden the sanity checks it made at the same time a regression, i.e. mixed in and out endpoints. Obviously it should have been not tested on real hardware at that time, but unluckily it didn't happen.
So, fix above mentioned typo and make device being enumerated again.
Fixes: 2b8bd606b1e6 ("mfd: dln2: More sanity checking for endpoints") Cc: Oliver Neukum <oneukum@suse.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/mfd/dln2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c index 984d6b438aca..3a729b196b1f 100644 --- a/drivers/mfd/dln2.c +++ b/drivers/mfd/dln2.c @@ -754,8 +754,8 @@ static int dln2_probe(struct usb_interface *interface, hostif->desc.bNumEndpoints < 2) return -ENODEV; - epin = &hostif->endpoint[0].desc; - epout = &hostif->endpoint[1].desc; + epin = &hostif->endpoint[1].desc; + epout = &hostif->endpoint[0].desc; if (!usb_endpoint_is_bulk_out(epout)) return -ENODEV; if (!usb_endpoint_is_bulk_in(epin)) -- 2.25.0
| |