lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] KVM: Add the check and free to avoid unknown errors.
Date
Hi:
Haiwei Li <lihaiwei.kernel@gmail.com> wrote:
> From: Haiwei Li <lihaiwei@tencent.com>
>
> If 'kvm_create_vm_debugfs()' fails in 'kzalloc(sizeof(*stat_data), ...)', 'kvm_destroy_vm_debugfs()' will be called by the final fput(file) in 'kvm_dev_ioctl_create_vm()'.
>
> Add the check and free to avoid unknown errors.

Add the check and free? According to the code,it seem what you mean is "add the check against free" ?

>
> Signed-off-by: Haiwei Li <lihaiwei@tencent.com>
>
> if (kvm->debugfs_stat_data) {
> - for (i = 0; i < kvm_debugfs_num_entries; i++)
> + for (i = 0; i < kvm_debugfs_num_entries; i++) {
> + if (!kvm->debugfs_stat_data[i])
> + break;
> kfree(kvm->debugfs_stat_data[i]);
> + }
> kfree(kvm->debugfs_stat_data);
> }
> }

If (!kvm->debugfs_stat_data[i]) is checked in kfree() internal. And break early seems have no different effect.
Could you please explain what unknown errors may occur? And how? Thanks.

\
 
 \ /
  Last update: 2020-02-15 03:01    [W:0.134 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site