Messages in this thread | | | Date | Sat, 1 Feb 2020 16:37:09 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH 5/6] net: bcmgenet: Fetch MAC address from the adapter |
| |
> @@ -3601,6 +3605,23 @@ static int bcmgenet_probe(struct platform_device *pdev) > !strcasecmp(phy_mode_str, "internal")) > bcmgenet_power_up(priv, GENET_POWER_PASSIVE); > > + if (dn) > + macaddr = of_get_mac_address(dn); > + else if (pd) > + macaddr = pd->mac_address; > + > + if (IS_ERR_OR_NULL(macaddr) || !is_valid_ether_addr(macaddr)) { > + if (has_acpi_companion(&pdev->dev)) > + bcmgenet_get_hw_addr(priv, dev->dev_addr); > + > + if (!is_valid_ether_addr(dev->dev_addr)) { > + dev_warn(&pdev->dev, "using random Ethernet MAC\n"); > + eth_hw_addr_random(dev); > + } > + } else { > + ether_addr_copy(dev->dev_addr, macaddr); > + } > +
Could you also maybe put in here somewhere a call to device_get_mac_address(), to support getting the MAC address out of ACPI?
Andrew
| |