Messages in this thread | | | Date | Mon, 3 Feb 2020 02:17:32 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH 2/6] net: bcmgenet: refactor phy mode configuration |
| |
On Sat, Feb 01, 2020 at 08:24:14AM -0800, Florian Fainelli wrote: > > > On 1/31/2020 11:46 PM, Jeremy Linton wrote: > > The DT phy mode is similar to what we want for ACPI > > lets factor it out of the of path, and change the > > of_ call to device_. Further if the phy-mode property > > cannot be found instead of failing the driver load lets > > just default it to RGMII. > > Humm no please do not provide a fallback, if we cannot find a valid > 'phy-mode' property we error out. This controller can be used with a > variety of configurations (internal EPHY/GPHY, MoCA, external > MII/Reverse MII/RGMII) and from a support perspective it is much easier > for us if the driver errors out if one of those essential properties are > omitted.
Hi Florian
Does any of the silicon variants have two or more MACs sharing one MDIO bus? I'm thinking about the next patch in the series.
Thanks Andrew
| |