Messages in this thread | | | Date | Wed, 2 Dec 2020 15:00:14 +0100 | From | Jonathan Neuschäfer <> | Subject | Re: [PATCH v4 3/7] mfd: Add base driver for Netronix embedded controller |
| |
On Wed, Dec 02, 2020 at 01:05:20PM +0000, Lee Jones wrote: > On Sun, 22 Nov 2020, Jonathan Neuschäfer wrote: [...] > > + /* Bail out if we encounter an unknown firmware version */ > > + switch (version) { > > + case 0xd726: /* found in Kobo Aura */ > > No magic numbers. > > Please submit a subsequent patch to define this.
Will do.
But I don't think I'll be able to give it a more meaningful name than NTXEC_VERSION_D726. I don't have a good overview of which versions appear in which devices. "0xd726 found in Kobo Aura" only means that; I don't know if it's the only version used in the Kobo Aura, and I don't know if the Kobo Aura is the only device where it is used.
Thanks, Jonathan Neuschäfer [unhandled content-type:application/pgp-signature] | |