Messages in this thread Patch in this message | | | From | Dwaipayan Ray <> | Subject | [PATCH v2] checkpatch: fix TYPO_SPELLING check for words with apostrophe | Date | Tue, 1 Dec 2020 12:53:20 +0530 |
| |
checkpatch reports a false TYPO_SPELLING warning for some words containing an apostrophe when run with --codespell option.
A false positive is "doesn't". Occurrence of the word causes checkpatch to emit the following warning:
"WARNING: 'doesn'' may be misspelled - perhaps 'doesn't'?"
Modify the regex pattern to be more in line with the codespell default word matching regex. This fixes the word capture and avoids the false warning.
Suggested-by: Joe Perches <joe@perches.com> Reported-by: Peilin Ye <yepeilin.cs@gmail.com> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com> --- Changes in v2: - Use the default codespell word regex. - Modify commit message to specify --codespell usage
scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3c86ea737e9c..bd6304f93e0a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3106,7 +3106,7 @@ sub process { # Check for various typo / spelling mistakes if (defined($misspellings) && ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) { - while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:\b|$|[^a-z@])/gi) { + while ($rawline =~ /(?:^|[^\w\-'`])($misspellings)(?:[^\w\-'`]|$)/gi) { my $typo = $1; my $typo_fix = $spelling_fix{lc($typo)}; $typo_fix = ucfirst($typo_fix) if ($typo =~ /^[A-Z]/); -- 2.27.0
| |