Messages in this thread | | | Subject | Re: [PATCH] iwlwifi: remove object duplication in Makefile | From | Johannes Berg <> | Date | Mon, 06 Jan 2020 16:51:25 +0100 |
| |
On Mon, 2020-01-06 at 16:54 +0900, Masahiro Yamada wrote: > The objects in $(iwlwifi-objs) $(iwlwifi-y) $(iwlwifi-m) are linked to > iwlwifi.ko . > > This line adds $(iwlwifi-m) to iwlwifi-objs, so the objects from > $(iwlwifi-m) are listed twice as the dependency of the module.
Are you sure? We have
obj-$(CONFIG_IWLWIFI) += iwlwifi.o
and then "iwlwifi-y += ...", but I was under the impression that iwlwifi.o didn't really pick up iwlwifi-m automatically, that's not something that you'd normally do, normally -m only makes sense to build a module using "obj-m", just here we do it for the mvm sub level stuff...
johannes
| |