lkml.org 
[lkml]   [2020]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] iwlwifi: remove object duplication in Makefile
On Tue, Jan 7, 2020 at 12:51 AM Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Mon, 2020-01-06 at 16:54 +0900, Masahiro Yamada wrote:
> > The objects in $(iwlwifi-objs) $(iwlwifi-y) $(iwlwifi-m) are linked to
> > iwlwifi.ko .
> >
> > This line adds $(iwlwifi-m) to iwlwifi-objs, so the objects from
> > $(iwlwifi-m) are listed twice as the dependency of the module.
>
> Are you sure? We have
>
> obj-$(CONFIG_IWLWIFI) += iwlwifi.o
>
> and then "iwlwifi-y += ...", but I was under the impression that
> iwlwifi.o didn't really pick up iwlwifi-m automatically, that's not
> something that you'd normally do, normally -m only makes sense to build
> a module using "obj-m", just here we do it for the mvm sub level
> stuff...
>
> johannes
>

I made a mistake.

iwlwifi-m is automatically handled since commit
cf4f21938e13ea1533ebdcb21c46f1d998a44ee8
but cfg/*.o objects are not liked to vmlinux
under the following combination:

CONFIG_IWLWIFI=y
CONFIG_IWLDVM=m
CONFIG_IWLMVM=m


Please ignore this patch.

Perhaps, I may come back to this patch,
but I need to change scripts/Makefile.lib beforehand.


--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2020-01-06 18:12    [W:0.075 / U:11.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site