Messages in this thread | | | From | Ong Boon Leong <> | Subject | [PATCH net v3 0/5] net: stmmac: general fixes for Ethernet functionality | Date | Wed, 22 Jan 2020 17:09:31 +0800 |
| |
Thanks to all feedbacks from community.
We updated the patch-series to below:-
1/5: It ensures that the real_num_rx|tx_queues are set in both driver probe() and resume(). So, move the netif_set_real_num_rx|tx_queues() into stmmac_hw_setup(). Added lock_acquired to allow to decide when to rtnl_lock() & rtnl_unlock() pair:- stmmac_open(): rtnl_lock() & rtnl_unlock() is not needed. stmmac_resume(): rtnl_lock() & rtnl_unlock() is needed.
2/5: It ensures that the previous value of GMAC_VLAN_TAG register is read first before for updating the register.
3/5: It ensures the GMAC IP v4.xx and above behaves correctly to:- ip link set <devname> multicast off|on
4/5: Added similar IFF_MULTICAST flag for xgmac2.
5/5: It ensures PCI platform data is using plat->phy_interface.
Rgds, Boon Leong
Changes from v2:- patch 1/5 - added control for rtnl_lock() & rtnl_unlock() to ensure they are used forstmmac_resume() patch 4/5 - added IFF_MULTICAST flag check for xgmac to ensure multicast works correctly.
v1:- - Drop v1 patches (1/7, 3/7 & 4/7) that are not valid.
Aashish Verma (1): net: stmmac: Fix incorrect location to set real_num_rx|tx_queues
Tan, Tee Min (2): net: stmmac: fix incorrect GMAC_VLAN_TAG register writting in GMAC4+ net: stmmac: xgmac: fix missing IFF_MULTICAST checki in dwxgmac2_set_filter
Verma, Aashish (1): net: stmmac: fix missing IFF_MULTICAST check in dwmac4_set_filter
Voon Weifeng (1): net: stmmac: update pci platform data to use phy_interface
.../net/ethernet/stmicro/stmmac/dwmac4_core.c | 9 +++++---- .../ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 19 ++++++++++++------- .../net/ethernet/stmicro/stmmac/stmmac_pci.c | 14 ++++++++------ 4 files changed, 26 insertions(+), 18 deletions(-)
-- 2.17.1
| |