Messages in this thread | | | Subject | Re: [PATCH] sched/cputime: remove irqtime_account_idle_ticks | From | Alex Shi <> | Date | Thu, 16 Jan 2020 11:44:28 +0800 |
| |
在 2020/1/16 上午11:17, Alex Shi 写道: > irqtime_account_idle_ticks just add longer call path w/o enough meaning. > We don't bother remove this function to simply code and reduce a > bit object size of kernel.
Sorry, above commit log need to revise as following:
irqtime_account_idle_ticks just add longer call path w/o enough meaning. We'd better to remove this function to simply code and reduce a bit object size of kernel.
> > Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Juri Lelli <juri.lelli@redhat.com> > Cc: Vincent Guittot <vincent.guittot@linaro.org> > Cc: Dietmar Eggemann <dietmar.eggemann@arm.com> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Ben Segall <bsegall@google.com> > Cc: Mel Gorman <mgorman@suse.de> > Cc: linux-kernel@vger.kernel.org > --- > kernel/sched/cputime.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c > index cff3e656566d..17640d145e44 100644 > --- a/kernel/sched/cputime.c > +++ b/kernel/sched/cputime.c > @@ -390,12 +390,7 @@ static void irqtime_account_process_tick(struct task_struct *p, int user_tick, > } > } > > -static void irqtime_account_idle_ticks(int ticks) > -{ > - irqtime_account_process_tick(current, 0, ticks); > -} > #else /* CONFIG_IRQ_TIME_ACCOUNTING */ > -static inline void irqtime_account_idle_ticks(int ticks) { } > static inline void irqtime_account_process_tick(struct task_struct *p, int user_tick, > int nr_ticks) { } > #endif /* CONFIG_IRQ_TIME_ACCOUNTING */ > @@ -505,7 +500,7 @@ void account_idle_ticks(unsigned long ticks) > u64 cputime, steal; > > if (sched_clock_irqtime) { > - irqtime_account_idle_ticks(ticks); > + irqtime_account_process_tick(current, 0, ticks); > return; > } > >
| |