Messages in this thread | | | Date | Mon, 2 Sep 2019 23:49:14 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/8] x86/platform/uv: Return UV Hubless System Type |
| |
> static inline bool is_early_uv_system(void) > { > return !((efi.uv_systab == EFI_INVALID_TABLE_ADDR) || !efi.uv_systab);
No need for the inner braces here.
But woudn't this be nicer as:
return efi.uv_systab != EFI_INVALID_TABLE_ADDR && efi.uv_systab;
anyway?
> +#define is_uv_hubless _is_uv_hubless
Why the weird macro indirection?
> -static inline int is_uv_hubless(void) { return 0; } > +static inline int _is_uv_hubless(int uv) { return 0; } > +#define is_uv_hubless _is_uv_hubless
And here again.
| |