lkml.org 
[lkml]   [2019]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/8] x86/platform/uv: Return UV Hubless System Type
>  static inline bool is_early_uv_system(void)
> {
> return !((efi.uv_systab == EFI_INVALID_TABLE_ADDR) || !efi.uv_systab);

No need for the inner braces here.

But woudn't this be nicer as:

return efi.uv_systab != EFI_INVALID_TABLE_ADDR && efi.uv_systab;

anyway?

> +#define is_uv_hubless _is_uv_hubless

Why the weird macro indirection?

> -static inline int is_uv_hubless(void) { return 0; }
> +static inline int _is_uv_hubless(int uv) { return 0; }
> +#define is_uv_hubless _is_uv_hubless

And here again.

\
 
 \ /
  Last update: 2019-09-03 08:49    [W:0.131 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site