lkml.org 
[lkml]   [2019]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/8] x86/platform/uv: Return UV Hubless System Type
On Tue, Sep 03, 2019 at 07:12:28AM -0700, Mike Travis wrote:
> > > +#define is_uv_hubless _is_uv_hubless
> >
> > Why the weird macro indirection?
> >
> > > -static inline int is_uv_hubless(void) { return 0; }
> > > +static inline int _is_uv_hubless(int uv) { return 0; }
> > > +#define is_uv_hubless _is_uv_hubless
> >
> > And here again.
> >
>
> Sorry, I should have explained this better. The problem arises because
> we have a number of UV specific kernel modules that support multiple
> distributions. And with back porting to earlier distros we cannot
> rely on the KERNEL_VERSION macro to define whether the source is being
> built for an earlier kernel. So this allows an ifdef on the function
> name to discover if the kernel is before or after these changes.

And none of these matter for upstream. We'd rather not make the code
more convouluted than required. If you actually really cared about these
modules you would simply submit them upstream.

\
 
 \ /
  Last update: 2019-09-03 17:42    [W:0.079 / U:0.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site