Messages in this thread | | | From | "Lad, Prabhakar" <> | Date | Fri, 27 Sep 2019 21:35:25 +0100 | Subject | Re: [Patch v4 2/8] media: i2c: ov2659: Fix sensor detection to actually fail when device is not present |
| |
On Fri, Sep 27, 2019 at 7:47 PM Benoit Parrot <bparrot@ti.com> wrote: > > Make sure that if the expected sensor device id register > is not recognized properly the failure is propagated > up so devices are not left partially initialized. > > Signed-off-by: Benoit Parrot <bparrot@ti.com> > Signed-off-by: Jyri Sarha <jsarha@ti.com> > --- > drivers/media/i2c/ov2659.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Cheers, --Prabhakar Lad
> diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c > index 17573257097d..efbe6dc720e2 100644 > --- a/drivers/media/i2c/ov2659.c > +++ b/drivers/media/i2c/ov2659.c > @@ -1330,11 +1330,12 @@ static int ov2659_detect(struct v4l2_subdev *sd) > unsigned short id; > > id = OV265X_ID(pid, ver); > - if (id != OV2659_ID) > + if (id != OV2659_ID) { > dev_err(&client->dev, > "Sensor detection failed (%04X, %d)\n", > id, ret); > - else { > + ret = -ENODEV; > + } else { > dev_info(&client->dev, "Found OV%04X sensor\n", id); > ret = ov2659_init(sd, 0); > } > -- > 2.17.1 >
| |