Messages in this thread | | | Date | Fri, 9 Aug 2019 01:03:12 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset |
| |
> After giving it more thought, I'm thinking about adding ncsi dt node > with following structure (mac/ncsi similar to mac/mdio/phy): > > &mac0 { > /* MAC properties... */ > > use-ncsi;
This property seems to be specific to Faraday FTGMAC100. Are you going to make it more generic?
> ncsi { > /* ncsi level properties if any */ > > package@0 {
You should get Rob Herring involved. This is not really describing hardware, so it might get rejected by the device tree maintainer.
> 1) mac driver doesn't need to parse "mac-offset" stuff: these > ncsi-network-controller specific settings should be parsed in ncsi > stack.
> 2) get_bmc_mac_address command is a channel specific command, and > technically people can configure different offset/formula for > different channels.
Does that mean the NCSA code puts the interface into promiscuous mode? Or at least adds these unicast MAC addresses to the MAC receive filter? Humm, ftgmac100 only seems to support multicast address filtering, not unicast filters, so it must be using promisc mode, if you expect to receive frames using this MAC address.
Andrew
| |