Messages in this thread Patch in this message | | | From | Lihong Kou <> | Subject | [f2fs-dev] [PATCH] f2fs: remove duplicate code in f2fs_file_write_iter | Date | Mon, 5 Aug 2019 15:27:24 +0800 |
| |
We will do the same check in generic_write_checks. if (iocb->ki_flags & IOCB_NOWAIT) && !(iocb->ki_flags & IOCB_DIRECT) return -EINVAL; just remove the same check in f2fs_file_write_iter.
Signed-off-by: Lihong Kou <koulihong@huawei.com> --- fs/f2fs/file.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 3e58a6f..50a87cf 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -3134,11 +3134,6 @@ static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from) goto out; } - if ((iocb->ki_flags & IOCB_NOWAIT) && !(iocb->ki_flags & IOCB_DIRECT)) { - ret = -EINVAL; - goto out; - } - if (!inode_trylock(inode)) { if (iocb->ki_flags & IOCB_NOWAIT) { ret = -EAGAIN; -- 2.7.4
| |