Messages in this thread | | | Date | Mon, 19 Aug 2019 18:58:03 +0300 | From | Ido Schimmel <> | Subject | Re: [PATCH net-next] netdevsim: Fix build error without CONFIG_INET |
| |
On Mon, Aug 19, 2019 at 08:08:25PM +0800, YueHaibing wrote: > If CONFIG_INET is not set, building fails: > > drivers/net/netdevsim/dev.o: In function `nsim_dev_trap_report_work': > dev.c:(.text+0x67b): undefined reference to `ip_send_check' > > Add CONFIG_INET Kconfig dependency to fix this. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: da58f90f11f5 ("netdevsim: Add devlink-trap support") > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Thanks for the patch.
> --- > drivers/net/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > index 48e209e..7bb786e 100644 > --- a/drivers/net/Kconfig > +++ b/drivers/net/Kconfig > @@ -505,7 +505,7 @@ source "drivers/net/hyperv/Kconfig" > > config NETDEVSIM > tristate "Simulated networking device" > - depends on DEBUG_FS > + depends on INET && DEBUG_FS > select NET_DEVLINK > help > This driver is a developer testing tool and software model that can > -- > 2.7.4 > >
| |