Messages in this thread | | | Date | Tue, 20 Aug 2019 17:08:04 +0300 | From | Ido Schimmel <> | Subject | Re: [PATCH net-next] netdevsim: Fix build error without CONFIG_INET |
| |
On Mon, Aug 19, 2019 at 02:59:00PM -0700, Jakub Kicinski wrote: > On Mon, 19 Aug 2019 20:08:25 +0800, YueHaibing wrote: > > If CONFIG_INET is not set, building fails: > > > > drivers/net/netdevsim/dev.o: In function `nsim_dev_trap_report_work': > > dev.c:(.text+0x67b): undefined reference to `ip_send_check' > > > > Add CONFIG_INET Kconfig dependency to fix this. > > > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Fixes: da58f90f11f5 ("netdevsim: Add devlink-trap support") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Hmm.. I'd rather the test module did not have hard dependencies on > marginally important config options. We have done a pretty good job > so far limiting the requirements though separating the code out at > compilation object level. The more tests depend on netdevsim and the > more bots we have running tests against randconfig - the more important > this is. > > This missing reference here is for calculating a checksum over a > constant header.. could we perhaps just hard code the checksum?
Sure. I was AFK today, will send a patch later today when I get home.
Thanks
| |