lkml.org 
[lkml]   [2019]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] checkpatch.pl: warn on invalid commit id
On Thu, Jul 25, 2019 at 5:07 AM Andrew Morton <akpm@linux-foundation.org> wrote:
> What does it do if we're not operating in a git directory? For example,
> I work in /usr/src/25 and my git repo is in ../git26.
>

If .git is not found, the check is disabled

> Also, what happens relatively often is that someone quotes a linux-next
> or long-term-stable hash. If the user has those trees in the git repo,
> I assume they won't be informed of the inappropriate hash?
>

In this case it won't warn, but this should not be a problem, as the
hash doesn't change following a merge.
The problem is just if the other tree gets rebased, or if the other
tree gets never merged, e.g. stable/linux-*

Cheers,


--
Matteo Croce
per aspera ad upstream

\
 
 \ /
  Last update: 2019-07-25 11:28    [W:0.192 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site