lkml.org 
[lkml]   [2019]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] checkpatch.pl: warn on invalid commit id
From
Date
On Thu, 2019-07-11 at 02:16 +0200, Matteo Croce wrote:
> It can happen that a commit message refers to an invalid commit id, because
> the referenced hash changed following a rebase, or simply by mistake.
> Add a check in checkpatch.pl which checks that an hash referenced by
> a Fixes tag, or just cited in the commit message, is a valid commit id.

Thanks Matteo, this seems sensible.

> $ scripts/checkpatch.pl <<'EOF'
> Subject: [PATCH] test commit
>
> Sample test commit to test checkpatch.pl
> Commit 1da177e4c3f4 ("Linux-2.6.12-rc2") really exists,
> commit 0bba044c4ce7 ("tree") is valid but not a commit,
> while commit b4cc0b1c0cca ("unknown") is invalid.
>
> Fixes: f0cacc14cade ("unknown")
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> EOF
> WARNING: Unknown commit id '0bba044c4ce7', maybe rebased or not pulled?
> #8:
> commit 0bba044c4ce7 ("tree") is valid but not a commit,
>
> WARNING: Unknown commit id 'b4cc0b1c0cca', maybe rebased or not pulled?
> #9:
> while commit b4cc0b1c0cca ("unknown") is invalid.
>
> WARNING: Unknown commit id 'f0cacc14cade', maybe rebased or not pulled?
> #11:
> Fixes: f0cacc14cade ("unknown")
>
> total: 0 errors, 3 warnings, 4 lines checked
>
> Signed-off-by: Matteo Croce <mcroce@redhat.com>
> ---
> scripts/checkpatch.pl | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a6d436809bf5..3b77279df13b 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2898,6 +2898,17 @@ sub process {
> }
> }
>
> +# check for invalid commit id
> + if ($in_commit_log && $line =~ /(^fixes:|\bcommit)\s+([0-9a-f]{6,40})\b/i) {
> + my $id;
> + my $description;
> + ($id, $description) = git_commit_info($2, undef, undef);
> + if (!defined($id)) {
> + WARN("UNKNOWN_COMMIT_ID",
> + "Unknown commit id '$2', maybe rebased or not pulled?\n" . $herecurr);
> + }
> + }
> +
> # ignore non-hunk lines and lines being removed
> next if (!$hunk_line || $line =~ /^-/);
>

\
 
 \ /
  Last update: 2019-07-11 11:04    [W:0.063 / U:3.364 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site