Messages in this thread | | | Date | Thu, 25 Jul 2019 16:28:31 -0700 | From | Kees Cook <> | Subject | Re: [tip:perf/urgent] perf/x86/intel: Mark expected switch fall-throughs |
| |
On Thu, Jul 25, 2019 at 04:18:56PM -0700, Joe Perches wrote: > On Thu, 2019-07-25 at 19:35 +0200, Peter Zijlstra wrote: > > Seriously though; I detest these patches and we really, as in _really_ > > should have done that attribute thing. > > At least it'll be fairly easy to convert to something > sensible later. > > Variants of the equivalent of: > > s@/* fallthrough */@fallthrough;@ > > with some trivial whitespace reformatting will read > _much_ better. > > It's pretty scriptable.
Yup; that's been my perspective. First let's finish markings (so so close right now), then we can do the next phase.
-- Kees Cook
| |