lkml.org 
[lkml]   [2019]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] perf/x86/intel: Mark expected switch fall-throughs
    In preparation to enabling -Wimplicit-fallthrough, mark switch
    cases where we are expecting to fall through.

    This patch fixes the following warnings:

    arch/x86/events/intel/core.c: In function ‘intel_pmu_init’:
    arch/x86/events/intel/core.c:4959:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
    pmem = true;
    ~~~~~^~~~~~
    arch/x86/events/intel/core.c:4960:2: note: here
    case INTEL_FAM6_SKYLAKE_MOBILE:
    ^~~~
    arch/x86/events/intel/core.c:5008:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
    pmem = true;
    ~~~~~^~~~~~
    arch/x86/events/intel/core.c:5009:2: note: here
    case INTEL_FAM6_ICELAKE_MOBILE:
    ^~~~

    Warning level 3 was used: -Wimplicit-fallthrough=3

    This patch is part of the ongoing efforts to enable
    -Wimplicit-fallthrough.

    Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    ---
    arch/x86/events/intel/core.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
    index bda450ff51ee..6154f052aa5f 100644
    --- a/arch/x86/events/intel/core.c
    +++ b/arch/x86/events/intel/core.c
    @@ -4957,6 +4957,7 @@ __init int intel_pmu_init(void)

    case INTEL_FAM6_SKYLAKE_X:
    pmem = true;
    + /* fall through */
    case INTEL_FAM6_SKYLAKE_MOBILE:
    case INTEL_FAM6_SKYLAKE_DESKTOP:
    case INTEL_FAM6_KABYLAKE_MOBILE:
    @@ -5006,6 +5007,7 @@ __init int intel_pmu_init(void)
    case INTEL_FAM6_ICELAKE_X:
    case INTEL_FAM6_ICELAKE_XEON_D:
    pmem = true;
    + /* fall through */
    case INTEL_FAM6_ICELAKE_MOBILE:
    case INTEL_FAM6_ICELAKE_DESKTOP:
    x86_pmu.late_ack = true;
    --
    2.21.0
    \
     
     \ /
      Last update: 2019-06-24 18:20    [W:3.060 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site