lkml.org 
[lkml]   [2019]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V2 2/3] clk: imx: Add support for i.MX8MN clock driver
Date
On 19-06-03 09:35:02, Anson.Huang@nxp.com wrote:
> From: Anson Huang <Anson.Huang@nxp.com>
>
> This patch adds i.MX8MN clock driver support.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> Changes since V1:
> - add GPIOx clocks.

...

> +static struct imx_pll14xx_clk imx8mn_sys_pll __initdata = {
> + .type = PLL_1416X,
> + .rate_table = imx8mn_pll1416x_tbl,
> +};
> +
> +static const char *pll_ref_sels[] = { "osc_24m", "dummy", "dummy", "dummy", };

All of these should be "static const char * const ".

> +static const char *audio_pll1_bypass_sels[] = {"audio_pll1", "audio_pll1_ref_sel", };
> +static const char *audio_pll2_bypass_sels[] = {"audio_pll2", "audio_pll2_ref_sel", };

...

> + clk_data.clks = clks;
> + clk_data.clk_num = ARRAY_SIZE(clks);
> + ret = of_clk_add_provider(np, of_clk_src_onecell_get, &clk_data);
> + if (ret < 0) {
> + pr_err("failed to register clks for i.MX8MN\n");
> + return -EINVAL;
> + }
> +
> + imx_register_uart_clocks(uart_clks);
> +
> + return 0;
> +}
> +CLK_OF_DECLARE_DRIVER(imx8mn, "fsl,imx8mn-ccm", imx8mn_clocks_init);

Any reason why this cannot be a platform driver ?

> --
> 2.7.4
>
\
 
 \ /
  Last update: 2019-06-03 09:31    [W:0.077 / U:10.412 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site