lkml.org 
[lkml]   [2019]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2 2/3] clk: imx: Add support for i.MX8MN clock driver
Date


> -----Original Message-----
> From: Leonard Crestez
> Sent: Monday, June 3, 2019 4:45 PM
> To: Anson Huang <anson.huang@nxp.com>; mturquette@baylibre.com;
> sboyd@kernel.org; robh+dt@kernel.org; mark.rutland@arm.com;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; catalin.marinas@arm.com; will.deacon@arm.com;
> maxime.ripard@bootlin.com; olof@lixom.net; horms+renesas@verge.net.au;
> jagan@amarulasolutions.com; bjorn.andersson@linaro.org;
> dinguyen@kernel.org; enric.balletbo@collabora.com; Aisheng Dong
> <aisheng.dong@nxp.com>; Jacky Bai <ping.bai@nxp.com>; Abel Vesa
> <abel.vesa@nxp.com>; l.stach@pengutronix.de; linux-clk@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Cc: dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH V2 2/3] clk: imx: Add support for i.MX8MN clock driver
>
> On 6/3/2019 4:33 AM, Anson.Huang@nxp.com wrote:
> > From: Anson Huang <Anson.Huang@nxp.com>
> >
> > This patch adds i.MX8MN clock driver support.
>
> > +#include "clk.h"
> > +
> > +#define PLL_1416X_RATE(_rate, _m, _p, _s) \
> > + { \
> > + .rate = (_rate), \
> > + .mdiv = (_m), \
> > + .pdiv = (_p), \
> > + .sdiv = (_s), \
> > + }
> > +
> > +#define PLL_1443X_RATE(_rate, _m, _p, _s, _k) \
> > + { \
> > + .rate = (_rate), \
> > + .mdiv = (_m), \
> > + .pdiv = (_p), \
> > + .sdiv = (_s), \
> > + .kdiv = (_k), \
> > + }
>
> These macros are shared with clk-imx8mm (and perhaps some future chips)
> so they should be moved to driver/clk/imx/clk.h

OK, will move them into clk.h in V3.

Anson.
\
 
 \ /
  Last update: 2019-06-03 11:02    [W:0.053 / U:20.144 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site