[lkml]   [2019]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v10 0/9] freezer for cgroup v2
This patchset implements freezer for cgroup v2.

It provides similar functionality as v1 freezer, but the interface
conforms to the cgroup v2 interface design principles, and it
provides a better user experience: tasks can be killed, ptrace works,
there is no separate controller, which has to be enabled, etc.

Patches (1), (2) and (3) are some preparational work, patch (4) contains
the implementation, patch (5) is a small cgroup kselftest fix,
patch (6) covers freezer adds 6 new kselftests to cover the freezer
functionality. Patchse (7) and (8) adding tracing points to simplify
the debugging process. Patch (9) adds corresponding docs.

- removed redundant fatal_signal_pending() check
- reworked vfork support
- minor cleanups
- rebase to cgroup/for-5.2

- added support for vfork
- added a kselftest test for vfork case
- several tests fixes/improvements
- renamed stopped* into frozen* across the patchset
- other minor fixes

- reworked/simplified cgroup frozen task accounting by merging nr_stopped
and nr_frozen and removing nr_tasks_to_freeze
- don't notify the parent process if the child is going from the stopped
to the frozen state

- handle properly the case, when a task is both stopped and frozen
- check for CGRP_FREEZE instead of CGRP_FROZEN in cgroup_exit()
- minor cosmetic changes and rebase

- reverted to clear TIF_SIGPENDING with additional checks before schedule(),
as proposed by Oleg Nesterov
- made cgroup v2 freezer working with the system freezer (by using
- make freezer working with SIGSTOPped and PTRACEd tasks
- added tests to cover freezing a cgroup with SIGSTOPped and PTRACEd tasks

- rewored cgroup state transition code (suggested by Tejun Heo)
- look at JOBCTL_TRAP_FREEZE instead of task->frozen in
recalc_sigpending(), check for task->frozen and JOBCTL_TRAP_FREEZE
in signal_pending_state() (suggested by Oleg Nesterov)
- some cosmetic changes in signal.c (suggested by Oleg Nesterov)
- cleaned up comments

- reading nr_descendants doesn't require taking css_set_lock anymore
- fixed docs based on Mike Rapoport's feedback
- fixed double irq lock found by Dan Carpenter

- dropped TASK_FROZEN for now, frozen tasks are put into TASK_INTERRUPTIBLE
state; it's probably not the final version, but the API question can be
discussed separately
- don't clear TIF_SIGPENDING before going to sleep, instead add
task->frozen check in signal_pending_state() and recalc_sigpending()
- cgroup-level counter are now synchronized using css_set_lock,
which simplified the whole code (e.g. per-cgroup works were removed)
- the amount of comments increased significantly
- many other improvements incorporating feedback from Tejun and Oleg

- fixed locking aroung calling cgroup_freezer_leave()
- added docs

Roman Gushchin (9):
cgroup: rename freezer.c into legacy_freezer.c
cgroup: implement __cgroup_task_count() helper
cgroup: protect cgroup->nr_(dying_)descendants by css_set_lock
cgroup: cgroup v2 freezer
kselftests: cgroup: don't fail on cg_kill_all() error in cg_destroy()
kselftests: cgroup: add freezer controller self-tests
cgroup: make TRACE_CGROUP_PATH irq-safe
cgroup: add tracing points for cgroup v2 freezer
cgroup: document cgroup v2 freezer interface

Documentation/admin-guide/cgroup-v2.rst | 27 +
include/linux/cgroup-defs.h | 33 +
include/linux/cgroup.h | 43 +
include/linux/sched.h | 2 +
include/linux/sched/jobctl.h | 2 +
include/trace/events/cgroup.h | 55 ++
kernel/cgroup/Makefile | 4 +-
kernel/cgroup/cgroup-internal.h | 8 +-
kernel/cgroup/cgroup-v1.c | 16 -
kernel/cgroup/cgroup.c | 151 +++-
kernel/cgroup/freezer.c | 647 +++++--------
kernel/cgroup/legacy_freezer.c | 481 ++++++++++
kernel/fork.c | 2 +
kernel/signal.c | 70 +-
tools/testing/selftests/cgroup/.gitignore | 1 +
tools/testing/selftests/cgroup/Makefile | 2 +
tools/testing/selftests/cgroup/cgroup_util.c | 58 +-
tools/testing/selftests/cgroup/cgroup_util.h | 5 +
tools/testing/selftests/cgroup/test_freezer.c | 851 ++++++++++++++++++
19 files changed, 2026 insertions(+), 432 deletions(-)
create mode 100644 kernel/cgroup/legacy_freezer.c
create mode 100644 tools/testing/selftests/cgroup/test_freezer.c


 \ /
  Last update: 2019-04-05 19:49    [W:0.268 / U:1.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site