Messages in this thread Patch in this message | | | From | Arnd Bergmann <> | Subject | [PATCH] misc: habanalabs: avoid HWMON dependency | Date | Mon, 4 Mar 2019 21:04:02 +0100 |
| |
When CONFIG_HWMON is disabled, we currently get a link error for this driver:
ERROR: "hwmon_device_unregister" [drivers/misc/habanalabs/habanalabs.ko] undefined! ERROR: "hwmon_device_register_with_info" [drivers/misc/habanalabs/habanalabs.ko] undefined!
As the hardware monitoring is not a required part of the functionality, make it possible to compile without HWMON by ignoring all that functionality depending on the configuration.
Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/misc/habanalabs/hwmon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/habanalabs/hwmon.c b/drivers/misc/habanalabs/hwmon.c index 77facd25c4a2..933746639831 100644 --- a/drivers/misc/habanalabs/hwmon.c +++ b/drivers/misc/habanalabs/hwmon.c @@ -423,7 +423,7 @@ int hl_hwmon_init(struct hl_device *hdev) struct device *dev = hdev->pdev ? &hdev->pdev->dev : hdev->dev; int rc; - if ((hdev->hwmon_initialized) || !(hdev->fw_loading)) + if (!IS_ENABLED(CONFIG_HWMON) || (hdev->hwmon_initialized) || !(hdev->fw_loading)) return 0; if (hdev->hl_chip_info->info) { @@ -451,7 +451,7 @@ int hl_hwmon_init(struct hl_device *hdev) void hl_hwmon_fini(struct hl_device *hdev) { - if (!hdev->hwmon_initialized) + if (!IS_ENABLED(CONFIG_HWMON) || !hdev->hwmon_initialized) return; hwmon_device_unregister(hdev->hwmon_dev); -- 2.20.0
| |