Messages in this thread | | | Subject | Re: [PATCH 5/5] perf/arm_dsu: Fix CPU hotplug races | From | Suzuki K Poulose <> | Date | Tue, 5 Feb 2019 11:40:31 +0000 |
| |
On 04/02/2019 17:09, Robin Murphy wrote: > Like other system PMUs which associate themselves with an arbitrary CPU > for housekeeping purposes, arm_dsu has a race between registering the > hotplug notifier and registering the PMU device, such that the hotplug > niotifier can potentially fire and attempt to migrate the PMU context > before the latter is valid. This is easily resolved by inhibiting > hotplug until both the notifier and PMU device are successfully set up. > > For the same reason, also suppress any synchronous notifier calls in the > cleanup path if PMU registration fails. > > Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Should we add :
Fixes: commit 7520fa99246dade7ab6 ("perf: ARM DynamIQ Shared Unit PMU support")
Either way:
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
| |