lkml.org 
[lkml]   [2019]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 00/12] qcom: dts: thermal cleanups
Hey
On Mon, Feb 18, 2019 at 06:05:14PM +0530, Amit Kucheria wrote:
> - Expose all temperature sensors on msm8916, msm996, msm8998, sdm845
> - split up the register address map for msm8998
> - standardize names of the various thermal-zones across boards to make it
> easy for test scripts to parse
>

I am generally fine with the effort but please fix the following
(applies for the whole series) wrt to required properties for DT
thermal:
a. Trip points for your zones
b. Cooling Mappings for zones that have passive trips.

> Amit Kucheria (12):
> arm64: dts: msm8998: thermal: split address space into two
> arm64: dts: msm8998: efficiency is not valid property
> arm64: dts: msm8916: thermal: Add sensor for modem
> arm64: dts: msm8996: thermal: Add temperature sensors near major
> peripherals
> arm64: dts: msm8998: thermal: Fix the cpu sensor numbers
> arm64: dts: msm8998: thermal: Fix the gpu sensor number
> arm64: dts: msm8998: thermal: GPU has two sensors, add the second
> arm64: dts: msm8998: thermal: Add temperature sensors near major
> peripherals
> arm64: dts: sdm845: thermal: Add temperature sensors near major
> peripherals
> arm64: dts: msm8998: thermal: Make trip names consistent
> arm64: dts: msm8916: thermal: Make trip names consistent
> arm64: dts: msm8996: thermal: Make trip names consistent
>
> arch/arm64/boot/dts/qcom/msm8916.dtsi | 30 +++--
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 122 ++++++++++++++++++--
> arch/arm64/boot/dts/qcom/msm8998.dtsi | 154 ++++++++++++++++++--------
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 91 +++++++++++++++
> 4 files changed, 328 insertions(+), 69 deletions(-)
>
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2019-02-20 02:27    [W:0.102 / U:2.108 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site